-
-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ponyfills #1692
Add Ponyfills #1692
Conversation
unicorn |
awesome-lint returns 👌and my eyes did not catch an error either. |
The term is polyfills I believe. Also you have to stick to the pr template. |
https://github.com/sindresorhus/ponyfill
I followed the instructions on the template. |
Ok, didnt know that. Thanks. I believe you followed the template, but I think here its required to check all the boxes, not remove everything. |
@Jogai I was going to, except there were no boxes to check. |
My mistake, there are no boxes. But I still think its common practice, if not a requirement to leave the template in. |
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
|
|
d6b251d this still doesn't describe what a ponyfill is. |
@sindresorhus Explaining what a Ponyfill is in one sentence is pretty tedious. I've updated the description again. |
Your Awesome list readme should also explain what it is. It's not enough to just link to a website.
"Cross-platform" is not correct. This is too specific. Ponyfills (and polyfills) are much more. |
Bump :) |
@sindresorhus Please re-review. |
The description in your readme should be more verbose. It should describe what polyfills are and then what ponyfills are. https://ponyfoo.com/articles/polyfills-or-ponyfills should also be in a |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Fixed! |
👍 |
|
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Description
https://github.com/Richienb/awesome-ponyfills
People can use these modules when looking to support older browsers or node versions without polluting the prototype.
Reviewed PRs
#1653
#1660
cc @sindresorhus