Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ponyfills #1692

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Add Ponyfills #1692

merged 5 commits into from
Jun 5, 2020

Conversation

Richienb
Copy link
Contributor

Description

https://github.com/Richienb/awesome-ponyfills

People can use these modules when looking to support older browsers or node versions without polluting the prototype.

Reviewed PRs

#1653
#1660

cc @sindresorhus

@Richienb
Copy link
Contributor Author

unicorn

@maehr
Copy link
Contributor

maehr commented Jan 30, 2020

awesome-lint returns 👌and my eyes did not catch an error either.

@Jogai
Copy link

Jogai commented Jan 31, 2020

The term is polyfills I believe. Also you have to stick to the pr template.

@Richienb
Copy link
Contributor Author

The term is polyfills I believe

https://github.com/sindresorhus/ponyfill

Also you have to stick to the pr template.

I followed the instructions on the template.

@Jogai
Copy link

Jogai commented Feb 1, 2020

Ok, didnt know that. Thanks.

I believe you followed the template, but I think here its required to check all the boxes, not remove everything.

@Richienb
Copy link
Contributor Author

Richienb commented Feb 1, 2020

@Jogai I was going to, except there were no boxes to check.

@Jogai
Copy link

Jogai commented Feb 3, 2020

My mistake, there are no boxes. But I still think its common practice, if not a requirement to leave the template in.

readme.md Outdated Show resolved Hide resolved
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus
Copy link
Owner

Includes a succinct description of the project/theme at the top of the readme. (Example) - https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md

@sindresorhus
Copy link
Owner

This pull request has a title in the format Add Name of List

@Richienb Richienb changed the title Add Awesome Ponyfills Add Ponyfills Feb 13, 2020
@sindresorhus
Copy link
Owner

d6b251d this still doesn't describe what a ponyfill is.

@Richienb
Copy link
Contributor Author

@sindresorhus Explaining what a Ponyfill is in one sentence is pretty tedious. I've updated the description again.

@sindresorhus
Copy link
Owner

Your Awesome list readme should also explain what it is. It's not enough to just link to a website.

Ponyfills for writing cross-platform code.

"Cross-platform" is not correct. This is too specific. Ponyfills (and polyfills) are much more.

@sindresorhus
Copy link
Owner

Bump :)

@Richienb
Copy link
Contributor Author

@sindresorhus Please re-review.

@sindresorhus
Copy link
Owner

The description in your readme should be more verbose. It should describe what polyfills are and then what ponyfills are.


https://ponyfoo.com/articles/polyfills-or-ponyfills should also be in a Article section in the list.

readme.md Outdated Show resolved Hide resolved
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@Richienb
Copy link
Contributor Author

Richienb commented Jun 2, 2020

Fixed!

@sindresorhus sindresorhus merged commit 2c4f454 into sindresorhus:master Jun 5, 2020
@sindresorhus
Copy link
Owner

@Richienb
Copy link
Contributor Author

Richienb commented Jun 5, 2020

👍

@sindresorhus
Copy link
Owner

Like polyfills but without overriding native APIs. => [Ponyfills](https://ponyfill.com) are like polyfills but without overriding native APIs.

DejanPerovic pushed a commit to DejanPerovic/awesome that referenced this pull request Jul 6, 2020
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants