-
-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Translations #1907
Add Translations #1907
Conversation
unicorn |
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
The description now describes the argument of the list, not the list itself.
I updated the description in the awesome readme to describe the argument, not the list. Meanwhile, I have some questions:
|
The pull request with the changes has been accepted. |
Added a PR to add: |
readme.md
Outdated
@@ -715,6 +715,7 @@ | |||
- [WP-CLI](https://github.com/schlessera/awesome-wp-cli#readme) - Command-line interface for WordPress. | |||
- [Credit Modeling](https://github.com/mourarthur/awesome-credit-modeling#readme) - Methods for classifying credit applicants into risk classes. | |||
- [Ansible](https://github.com/KeyboardInterrupt/awesome-ansible#readme) - A Python-based, open source IT configuration management and automation platform. | |||
- [Translations](https://github.com/mbiesiad/awesome-translations#readme) - Tools to help with localization and translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your entry here should include a short description about the project/theme of the list. It should not describe the list itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the description, tell me if it's okay now
I think the list is misnamed. It's not generally about translations, but specifically about translation tools. |
Generally, I think the list needs more work. |
Updated the description to follow the guidelines.
Sorry, the description I wrote was wrong. In fact, the list not only contains tools for translation and localization but also articles that explain how to perform the localization of sites, apps, programs, etc. And in general about what localization, internationalization and globalization are (l10n, i18n and g11n), these days however we will add articles on translation and other elements to the list (which is not very long anyway and grows slowly because it contains only the best on these topics, not all, adhering to your guidelines for an awesome list). |
Item descriptions should not be title-case. |
The current description is not good enough. |
You should explain all those acronyms. |
|
|
Your email is not https://github.com/mbiesiad/awesome-translations/blob/main/CODE-OF-CONDUCT.md |
Hi All. Fixed: ✅ e-mail update, ✅ platforms section, ✅ acronyms, ✅ title-case, ✅ blog' descr. prefix, ✅ main descr. |
Now everything seems ok to me too, we have also added some books to the list. |
readme.md
Outdated
@@ -715,6 +715,7 @@ | |||
- [WP-CLI](https://github.com/schlessera/awesome-wp-cli#readme) - Command-line interface for WordPress. | |||
- [Credit Modeling](https://github.com/mourarthur/awesome-credit-modeling#readme) - Methods for classifying credit applicants into risk classes. | |||
- [Ansible](https://github.com/KeyboardInterrupt/awesome-ansible#readme) - A Python-based, open source IT configuration management and automation platform. | |||
- [Translations](https://github.com/mbiesiad/awesome-translations#readme) - Adaptation of a text or a speech from one language to many others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could come up with a better description on what "translation" is.
one language to many others.
It doesn't have to be "many others". It could be one other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote more options and variants
- "Transfer of the meaning of a text from one language to another."
- "The transfer of the meaning of a text from one language to another."
- "The process of translating words or text from one language into another." - From Oxford English Dictionary
- "Translation is the communication of the meaning of a source-language text by means of an equivalent target-language text." - Wikipedia
- "The communication of the meaning of a source-language text by means of an equivalent target-language text."
- "Communication of the meaning of a source-language text by means of an equivalent target-language text."
Tell me if there is one you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go with:
The transfer of the meaning of a text from one language to another.
Linkify all the terms in |
|
You need to fix the merge conflict. |
|
Fixed everything except the description and the merge conflict (I will fix both after I get feedback on description) @sindresorhus. |
Done everything. |
https://github.com/mbiesiad/awesome-translations
This list contains libraries, platforms, apps and articles about translation and localization. This list should be included because languages are barriers for people, and such a list can help a little to bridge those barriers by helping developers localize their apps, introducing new translation technologies and new projects in this field.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.