Move to TypeScript

[sneljo1]

Got everything sorted out as requested. I did not add dot paths yet because we should get a good base first. That should be a seperate PR.

Everything is nicely typed now. The only thing that break for now, and I want your opinion on this first, is the schema. The schema now requires the enum JSONSchemaType for defining the types. I feel like that might be annoying for users, they will need to fix all their schemas. WDYT?

Fixes #86

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #86: Improve the TypeScript types

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[sindresorhus]

Make sure you look at and address all the feedback in the original PR. For example: #96 (comment)

[sindresorhus]

The schema now requires the enum JSONSchemaType for defining the types.

What changed that makes it require this?

[sneljo1]

The schema now requires the enum JSONSchemaType for defining the types.

What changed that makes it require this?

Allright, nevermind. This is also a typing issue. Because it does support strings. I will look at your comments later today.

[sneljo1]

All comments have been resolved. Tests seem to be fine, except for the Failed to load plugin 'unicorn' declared in 'BaseConfig error on Node 8.

[sindresorhus]

I don't see #104 (comment) being handled.

[sindresorhus]

This is not done: #104 (comment)

[sindresorhus]

#104 (comment) is not resolved.

[sneljo1]

I have had other priorities, I will pick this up in the week of the 20th of April

[sneljo1]

I've dealt with the fixes. I have also applied all the changes that happend on master to the typescript version. As per 5d25f2f and dd88556

[sindresorhus]

Tests are not passing. Try removing xo from https://github.com/sindresorhus/conf/pull/104/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R18 and run npm test locally and ensure it passes.

[sneljo1]

I think it's ok now. The tests weren't working, implemented them like in https://github.com/sindresorhus/got/. The linter issues are fixed and I improved the typing for .get

[sindresorhus]

Can you add a type test to confirm #104 (comment) is working?

[sindresorhus]

Travis is still failing.

[sneljo1]

Allright, looked at it again and fixed the problem. But there are still some issues.

1. The xo package requires get-stdin which has a await, so either we have to upgrade the node version or downgrade xo
2. Then, I have this on my mac as well. The 2 watch tests fail. I debugged this to being fs.watch not working properly. This does work when using fs.watchFile. It's really strange. I'm not sure what the difference is since it is just a node module. We now do require node 8.3 instead of 8 for on of the xo rules, but I don't think that should be the problem.

[sindresorhus]

1. I plan to require Node.js 10 after this PR.
2. This is failing in master too. You don't have to worry about that. Probably related to fs,macos: fs.watch() behavior change in node >= 10.16.0 nodejs/node#29460

[sindresorhus]

Thanks for working on this! Looks great now 🙌🏻

[sneljo1]

Ah allright, glad I could help. I will be able to benefit from this as well in my app 🙂

[fregante]

As far as I know prepare is meant to replace prepublishOnly so you don't need both.

However I've been using the more specific prepack which feels like it's the exact moment when files should be built: right before the tar.gz is created.

[sindresorhus]

As far as I know prepare is meant to replace prepublishOnly so you don't need both.

Yes, but it's a mess since old npm version use prepare, new ones use prepublishOnly, and future ones will use prepare but with it will work differently. I'm not sure why we use both here. Maybe look at the git commits/blame.

However I've been using the more specific prepack which feels like it's the exact moment when files should be built: right before the tar.gz is created.

Does that one also work when users install a Git commit hash directly? npm i sindresorhus/conf#ad32d2

[fregante]

prepack: run BEFORE a tarball is packed (on npm pack, npm publish, and when installing git dependencies)

[fregante]

Compared with:

prepare: Run both BEFORE the package is packed and published, on local npm install without any arguments, and when installing git dependencies (See below). This is run AFTER prepublish, but BEFORE prepublishOnly.

[sindresorhus]

be69402