Add target option
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pended Motivation: Focus traps (in for instance modals) might break `copy-text-to-clipboard` as `document.body` is outside its ‘area of operation’. By allowing the consumer to specify an append target within the focus trap, this would no longer be an issue.
sindresorhus
requested changes
Mar 27, 2020
|
Can you update https://github.com/sindresorhus/copy-text-to-clipboard/blob/master/index.d.ts too? See https://github.com/sindresorhus/typescript-definition-style-guide#documentation for how to define the option. |
sindresorhus
reviewed
Apr 4, 2020
Omit the word 'optionally' as it is made clear from the context of the options object.
sindresorhus
changed the title
target option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Focus traps (in for instance modals) might break
copy-text-to-clipboardasdocument.bodyis outside its ‘area of operation’. By allowing the consumer to specify an append target within the focus trap, this would no longer be an issue.