Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new max_line_length property #45

Closed
wants to merge 2 commits into from
Closed

Add support for new max_line_length property #45

wants to merge 2 commits into from

Conversation

naoyukik
Copy link

for the time being I was corresponding max_line_length to rulers.

@sindresorhus
Copy link
Owner

I see no such property => http://editorconfig.org

@naoyukik
Copy link
Author

@sindresorhus
Copy link
Owner

Alright, from its description:

Forces hard line wrapping after the amount of characters specified

Shouldn't it change "Word Wrap Column" as that actually enforces the line-width instead of "Rulers" which only creates a guide?

Also needs to be added to the docs.

@naoyukik
Copy link
Author

support wrap_width settings.

Is it necessary to force the 'word_wrap'?
I want to choose the 'word_wrap' sublime text settings yourself.

@sindresorhus
Copy link
Owner

Is it necessary to force the 'word_wrap'?

That's the whole point of the property though. I think hard wrapping is totally dumb as all editors supports soft wrapping which gives the user the ability to set their preferred wrapping, but many projects have a set hard wrapping requirement, and the point of this property is to enforce that.

@naoyukik
Copy link
Author

I read the "editorconfig.vim".
It is written in the comments of "max_line_length".
"highlight the columns following max_line_length".
I used, it was not a new line.

wrap_width set of sublime text also I seem unnecessary.

@sindresorhus
Copy link
Owner

I'm not sure what more to say that will not be a repeat of #45 (comment).

Happy to receive a PR that implements hard-wrapping.

@xuhdev
Copy link

xuhdev commented Mar 14, 2015

@naoyukik The Vim plugin not only highlight the column, but also set textwidth to max_line_length, which means you should get an automatic line breaking when your typing exceeds the max_line_length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants