-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter behaviour of default actions/roles e.g. when copying a link #43
Comments
I agree with the problem, do you have any suggestions on how we could solve this? |
I personally prefer your first suggestion, it is clean and "future-proof" for extra options which might be action-specific. If they want a general hook function, they can by adding it as a transform for each of them. The second suggestion is less work on our side, but I think it would become messy when someone needs to implement custom behaviour for all of them. Sure it is much easier when you want to manipulate all incoming text/urls/strings (e.g. replacing http with https) So I think both of them have some use cases, but the first one seems less of a hurdle for the end user. |
Hi,
This issue is related to #14, but I think it is appropriate to discuss it separately.
The specific use case for altering the behaviour of the default roles is found in Caprine.
Currently it is impleted that clicking on links removes the tracking bits from the URL.
This is not the case when using the context-menu (e.g. "Copy Link").
Therefore it would be useful to be able to modify the content of that link without the need to rewrite some of the boilerplate.
Thoughts?
The text was updated successfully, but these errors were encountered: