New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type compatibility with p-event #115

Merged

sindresorhus merged 2 commits into sindresorhus:main from younggglcy:GODLiangCY/issue90

Feb 13, 2024

Contributor

younggglcy commented Feb 13, 2024

This PR should close #90

Changes made in this PR:

bump p-event dependency version to latest
replace outdated pEvent.iterator with pEventIterator
explicitly passing the generic argument to pEventIterator to make types match, because Emittery.on's type is more narrow than EventEmitter in p-event, which infer specific literal strings as its argument, e.g. "data", "error" in this case.

younggglcy added 2 commits

February 13, 2024 21:43


          chore: bump p-event

fbd5c7e


          feat: make type compatible with p-event

aee7ec2

sindresorhus merged commit 2eea7f7 into sindresorhus:main

2 checks passed

younggglcy deleted the GODLiangCY/issue90 branch

March 16, 2024 16:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet