Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by severity first? #8

Closed
jamestalmage opened this issue Apr 30, 2016 · 1 comment
Closed

Sort by severity first? #8

jamestalmage opened this issue Apr 30, 2016 · 1 comment

Comments

@jamestalmage
Copy link
Contributor

jamestalmage commented Apr 30, 2016

Sorting by line number makes a lot of sense, but I ignore most warnings anyway (or rather, most warnings I see are ones I evaluated and decided to ignore at some point in the past).

I think it might make sense to put the higher severity error at the bottom of the list (since we are scrolling up in our terminal to view it anyways.

Also, it might make sense to reorder the files so those with only warnings and no errors come first.

This gets that one error you missed down at the bottom of the output every time.

@sindresorhus
Copy link
Owner

I think it might make sense to put the higher severity error at the bottom of the list (since we are scrolling up in our terminal to view it anyways.

👍 Should still be ordered by line number per warning and error group though.

warn 1:4
warn 10:2
error 1:1
error 14:6

Also, it might make sense to reorder the files so those with only warnings and no errors come first.

👍

kevva added a commit that referenced this issue Jun 1, 2016
kevva added a commit that referenced this issue Sep 6, 2016
sindresorhus pushed a commit that referenced this issue Sep 16, 2016
* Sort results by severity

Fixes #8.

* Lines with only warnings should be listed first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants