consistent-function-scoping: Ignore anything containing JSX
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
MrHen
commented
Sep 18, 2019
| }, | ||
| JSXElement: () => { | ||
| // Turn off this rule if we see a JSX element because scope | ||
| // references does not include JSXElement nodes. |
There was a problem hiding this comment.
Copying comment from @sindresorhus:
Can you open an ESLint issue about this afterwards?
Looks like there was a similar issue opened here: eslint/eslint#3622
I can try getting something like that hooked up. Ideally, if someone who uses eslint-plugin-unicorn also had eslint-plugin-react then it would "just work". I'm not sure if we can realistically test for that, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376.
Depends on #378.
I could not find a quick way to include JSX elements in the reference detection. It looks like the scope utilities don't recognize JSX.
We can circle back around to this later but I wanted to get the bugs cleared out first.