Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows test related to shell option #185

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Fix Windows test related to shell option #185

merged 1 commit into from
Mar 6, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Mar 6, 2019

This fixes #56.

Using shabangs on Windows currently only works in non-shell mode, but not in shell mode (when shell option is either true or a string). This is done through cross-spawn. I think the current behavior is the correct behavior.

The original test failed because it tried to fire a shabang with cmd.exe. Instead I've fired the binary through node which works.

@sindresorhus sindresorhus merged commit eac23b0 into sindresorhus:master Mar 6, 2019
@ehmicky ehmicky deleted the feature/fix-test-windows branch March 6, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix shell option in execa.shell() on Windows
2 participants