Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add silent option #29

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Add silent option #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ac041a
Add `silent` option
medusalix Feb 21, 2019
cc86a48
Trigger travis
medusalix Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ module.exports = async (inputs, options = {}) => {
inputs.map(input => handleKill(input))
);

if (errors.length > 0) {
if (errors.length > 0 && !options.silent) {
throw new AggregateError(errors);
}
};
7 changes: 7 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ Ignore capitalization when killing a process.

Note that the case is always ignored on Windows.

##### silent

Type: `boolean`<br>
Default: `false`

Suppress all error messages. For example: `Process doesn't exist`.


## Related

Expand Down
5 changes: 5 additions & 0 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,8 @@ test('kill from port', async t => {
test('error when process is not found', async t => {
await t.throwsAsync(fkill(['notFoundProcess']), /Killing process notFoundProcess failed: Process doesn't exist/);
});

test('suppress errors when silent', async t => {
await t.notThrowsAsync(fkill(['123456', '654321'], {silent: true}));
await t.notThrowsAsync(fkill(['notFoundProcess'], {silent: true}));
});