Introduce shallow gitignore parsing for better performance #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
.gitignore
handling to only scan for ignore files at$CWD/.gitignore
, which results in better performance ofglobby
runs.Previously globby scanned for
**/.gitignore
, which increased execution time in relation to the number of files in `cwd.This does not change the ignore filter to be applied before
glob
tasks are created.Considerations
.gitignore
files be supported?Probably should move benchmarking for.gitignore
handling here${gitRoot}/
instead? (How to handle non-git dirs then?)Details
Tested via https://github.com/pixelass/ava-xo-test:
Before
The area with red borders signifies time spent in
getGitIgnoreFilter
CPU profile before
After
CPU profile after