Add all helper functions in the same loop #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevva
suggested changes
Jun 16, 2017
index.js
Outdated
|
|
||
| helpers.forEach(el => { | ||
| got[el] = (url, opts) => got(url, Object.assign({}, opts, {method: el})); | ||
| ].forEach(method => { |
There was a problem hiding this comment.
@kevva Done 👍
Why is for of preferable over forEach?
There was a problem hiding this comment.
Personal preference, consistency, and it's faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed the HTTP method helper functions are added to
gotin a forEach loop and then again togot.streamin a for in loop a few lines down. They might as well be added in the same loop.