-
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
81f643c
to
60624df
Compare
e11106d
to
e14baa5
Compare
Nice!
Should be mentioned in the readme ;) |
For sure. I'll tidy up the readme last, to get everything that changes. On Sunday, September 28, 2014, Sindre Sorhus notifications@github.com
Rob Wierzbowski |
I just found an issue with that, namely incremental builds with gulp-watch. E.g., this is a (IMO) common use case that would no longer work: gulp.task('default', function() {
var srcGlob = 'scss/*.scss';
return gulp.src(srcGlob)
.pipe(watch(srcGlob, function(files) {
return files
.pipe(sass())
.pipe(gulp.dest('css'));
}));
}); |
Good point. For simple tasks if we get sass-cache working we'd be ok. There are a bunch of gulp incremental filtering tasks — I wonder if one will work with this style plugin. The adapter approach solves so many problems I think even with only a partial support case it's worth it. |
Added @sindresorhus's readme note and @UltCombo's incremental build note to the issue tasks. |
0127df9
to
d94161e
Compare
Waiting for this... |
e3a8dbf
to
9b0d879
Compare
Sourcemaps working for |
Yay nice work @robwierzbowski! 😄 |
9b0d879
to
8099bc4
Compare
Re: sourcemap integration, here's a related Sass issue. The answer to this will change how we deal with sourcemaps. |
fabb3e5
to
9f70376
Compare
Temporarily adding this for easier work with logs and errors. This is the keystone of the caching issue that has to be resolved.
This makes sourcemaps option a bool in order to provide consistent integration with gulp- sourcemaps. If people complain we can allow sass option strings to pass through and do gulp style when the option is passed a bool.
I've been using these, probably good to make available to everyone else. Directions on use in the html file.
- Update for new sourcemaps - Update for sourcemap adapter - Add recipe for running two sass tasks at the same time I explored adding smart container switching to the plugin but I think it will interfere with any type of incremental build / caching that we add. Specifying an option isn't a hard request to make to our users either.
Also add a note that these options are incomplete.
If there are spaces or special characters in the path or file name the two paths won't match up and cancel out when we pass them to path.relative. Ensures both paths are in a decoded state. Adds tests as well.
…st above I added this initally thinking that we might have images in the compiled folder. We may once we get to compass support but for now removing because untill we need it, YAGNI.
Logging as a gulp command line argument has been given the nay-no: gulpjs/gulp#107. The maintainers of gulp say gulpfiles are node applications, and options should be managed in code. We will let people get some extra output with the verbose optiion.
Copied from `sass -h`, version 3.4.8
OK, that's it. Ready to make 1.0 real and go from there. |
Gulp source adapter, release 1.0
Published 1.0.0. OK, now to take care of these: https://github.com/sindresorhus/gulp-ruby-sass#important |
Woot! Awesome work @robwierzbowski :) |
ahaha |
1.0 will implement the plugin as a vinyl stream source, similar to a vinyl adapter, but only implementing the
src
part, and usinggulp.watch
andgulp.dest
for the rest.Interface:
Because it's basically spawn that pipes into a gulp stream I think the only things we'd have to touch in the output would be sourcemaps (of course) and maybe error handling.
We would lose the ability to add the plugin at any point in the pipe. But aside from linting, which could be a separate task, I've seen no common reason to transform the Sass files before compiling them to CSS. The maintenance / allowing 90% of users to use Sass like they would on the cli or with Grunt outweighs supporting those edge cases.
update
inline
andnone
update
directory compilationfile
Allow parallel calls to the plugin without jumble of CSS filesInstead of making this automatic I expanded documentation of the container option, added a recipe.Feature level releases after 1.0 (or if I have time during the alpha)
src
property that delegates between dirs, files, and file globs