-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to properly detect "online" under OS X 10.12 (aka macOS Sierra) #29
Comments
A working ICMP doesn't really tell you much. Try actually connecting to a port, e.g. |
@silverwind Those all work. I should have mentioned that browsing is fine. The problem, I now believe, occurs because I'm running within a corporate network. I've not had the time to determine what's not working, but an assumption made, likely by is-reachable, is too restrictive for many networks. |
|
@silverwind If the browser runs with a proxy, it is set automatically (browsers allow this) and I have no control, and so cannot test. But I suspect that is the issue. |
You can possibly detect a system proxy with Also I found this node module which looks promising: https://github.com/sholladay/os-proxy |
I don't think this is to do with corporate networks or proxies. I am using macOS 10.12, connecting over Wi-Fi with no proxy and can browse fine, make p2p connections, etc. but |
Rewrite module to use the following checks in parallel: - OpenDNS IP check - icanhaz IP check - Apple Captive Portal test This should fix all current issues with the module because the new methods allow verification of the response, so any kind of tampering should be detected. Fixes: #32 Fixes: #30 Fixes: #29 Fixes: #25 Fixes: #22 Fixes: #15
* rewrite to use public-ip check Rewrite module to use the following checks in parallel: - OpenDNS IP check - icanhaz IP check - Apple Captive Portal test This should fix all current issues with the module because the new methods allow verification of the response, so any kind of tampering should be detected. Fixes: #32 Fixes: #30 Fixes: #29 Fixes: #25 Fixes: #22 Fixes: #15 * Update readme.md
"pings" to all of the hosts in hostname.js work fine as does full browsing. Yet, this module returns "false" when running under OS X 10.12 (aka macOS Sierra).
The text was updated successfully, but these errors were encountered: