Test coverage for is(value)
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gioragutt
requested changes
Apr 19, 2019
test/test.ts
Outdated
| @@ -753,6 +800,13 @@ test('is.inRange', t => { | |||
| test('is.domElement', t => { | |||
| testType(t, 'domElement'); | |||
| t.false(is.domElement({nodeType: 1, nodeName: 'div'})); | |||
|
|
|||
| t.is(is(createDomElement('div')), 'HTMLDivElement'); | |||
There was a problem hiding this comment.
I'd refactor this to something like:
const htmlTagNameToTypeName = {
span: 'HTMLSpanElement',
...
}
Object.entries(htmlTagNameToTypeName).forEach(([tagName, typeName]: string[]) => {
const domElement = createDomElement(tagName);
t.is(is(domElement), typeName);
})
|
Turns out |
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.
I chose a slightly different path than the one suggested in the issue. There were only two minor annoyances that you might want cleaned up / tweaked:
TypeName.GeneratorFunctionhas a value of'GeneratorFunction'but the value returned fromisis'Generator'. If the actual string of'GeneratorFunction'is not being used, could we change it to'Generator'?TypeName. They were also mixed into a single test type ofdomElementwhich meant that thetypenamehelper would not work properly. I don't think anything needs to be changed here; just calling it out.