Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Request to TimeoutError #267

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Add Request to TimeoutError #267

merged 1 commit into from
Jul 12, 2020

Conversation

ByScripts
Copy link
Contributor

@ByScripts ByScripts commented Jul 2, 2020 •
edited by sindresorhus
Loading

This is a fix #266 I opened earlier.

I'm not a Ky internal expert, so it's opened to discussion, improvement and suggestions.

sholladay
sholladay approved these changes Jul 11, 2020
View reviewed changes
Copy link
Collaborator

@sholladay sholladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Conceptually, it's a bit weird that the timeout() function executes the fetch. But I don't have any better suggestions at the moment. The implementation looks fine.

@sindresorhus sindresorhus changed the title Fix #266 - Add Request to TimeoutError Add Request to TimeoutError Jul 12, 2020
@sindresorhus sindresorhus merged commit b9dbd19 into sindresorhus:master Jul 12, 2020
@arty-name arty-name mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sholladay sholladay sholladay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include request URL in TimeoutError message
3 participants
@ByScripts @sholladay @sindresorhus