Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Compatibility with SvelteKit #512

Closed
wants to merge 3 commits into from
Closed

fix: Compatibility with SvelteKit #512

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7235b86
fix: Compatibility with SvelteKit
codercms Jun 11, 2023
4408a06
Update "xo" version to be able to run tests
codercms Jun 11, 2023
89d6039
Merge remote-tracking branch 'origin/main' into fix/response-clone
codercms Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions source/core/Ky.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,25 +83,26 @@ export class Ky {
ky.request.headers.set('accept', ky.request.headers.get('accept') || mimeType);

const awaitedResult = await result;
const response = awaitedResult.clone();

if (type === 'json') {
const response = awaitedResult.clone();

if (response.status === 204) {
return '';
}

const arrayBuffer = await response.clone().arrayBuffer();
const arrayBuffer = await response.arrayBuffer();
const responseSize = arrayBuffer.byteLength;
if (responseSize === 0) {
return '';
}

if (options.parseJson) {
return options.parseJson(await response.text());
return options.parseJson(await awaitedResult.text());
}
}

return response[type]();
return (awaitedResult as Response)[type]();
};
}

Expand Down