Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support indent level as option #241

Merged
merged 5 commits into from
Feb 6, 2024
Merged

feat: support indent level as option #241

merged 5 commits into from
Feb 6, 2024

Conversation

dylanarmstrong
Copy link
Contributor

@dylanarmstrong dylanarmstrong commented Jun 9, 2023 •
edited by sindresorhus
Loading

Fixes #240

@LitoMore
Copy link
Contributor

The index.test-d.ts file needs to be updated.

@dylanarmstrong
Copy link
Contributor Author

dylanarmstrong commented Aug 1, 2023 •
edited
Loading

The index.test-d.ts file needs to be updated.

Thanks, but per the attached issue, I’m unsure the project is going to actually use this PR. If I get approval there that this is wanted from maintainers, I’ll update this PR.

Edit 30/8: rebased against main to fix conflict with this file.

@dylanarmstrong
Copy link
Contributor Author

Hi, is there any update on this?

sindresorhus
sindresorhus requested changes Feb 4, 2024
View reviewed changes
readme.md Outdated
Type `number`\
Default: `2`

Indentation to use on helpText.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a better description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

source/index.d.ts Outdated
/**
Indentation to use on helpText.

@default true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@dylanarmstrong
Copy link
Contributor Author

Thanks for the review @sindresorhus, I've updated the PR.

@sindresorhus sindresorhus merged commit e9a55cd into sindresorhus:main Feb 6, 2024
3 checks passed
@scottwad scottwad mentioned this pull request Sep 24, 2024
Open
@Aroc902322 Aroc902322 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Proposal - Disable Indent
3 participants
@dylanarmstrong @LitoMore @sindresorhus