Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background option for macOS #126

Merged
merged 4 commits into from Apr 7, 2019
Merged

Add background option for macOS #126

merged 4 commits into from Apr 7, 2019

Conversation

@sunknudsen
Copy link
Contributor

@sunknudsen sunknudsen commented Apr 4, 2019

@sindresorhus Do I need to submit a PR to https://github.com/DefinitelyTyped/DefinitelyTyped for @types/code?

Fixes #3

@sunknudsen sunknudsen mentioned this pull request Apr 4, 2019
@sunknudsen
Copy link
Contributor Author

@sunknudsen sunknudsen commented Apr 6, 2019

@sindresorhus Have a PR ready for DefinitelyTyped. Waiting for you to merge this PR first. Have feedback? Thanks! https://github.com/sunknudsen/DefinitelyTyped/commit/64614c187020a6e8afca8ec63357a4dbad20f473

@sindresorhus sindresorhus changed the title Implemented background feature to fix #3 on macOS Add background option for macOS Apr 7, 2019
sindresorhus added 3 commits Apr 7, 2019
@sindresorhus sindresorhus merged commit 6a2b11b into sindresorhus:master Apr 7, 2019
1 check failed
1 check failed
@travis-ci
Travis CI - Pull Request Build Errored
Details
@sunknudsen
Copy link
Contributor Author

@sunknudsen sunknudsen commented Apr 7, 2019

DefinitelyTyped PR has been submitted: DefinitelyTyped/DefinitelyTyped#34538

@sunknudsen sunknudsen deleted the sunknudsen:background-feature branch Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants