Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object.deepValuesOfType validator - fixes #51 #53

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Conversation

SamVerschueren
Copy link
Collaborator

Fixes #51.

Added the type definitions for is-plain-obj manually here. Will try to PR it to DefinitelyTyped when I find some time. Feel free to provide feedback in the meantime.

@SamVerschueren SamVerschueren mentioned this pull request Feb 12, 2018
87 tasks
@kevva
Copy link
Contributor

kevva commented Feb 12, 2018

Did you discuss using the name deepValuesOfType? I get why valuesOfTypeDeep might be better, I usually put "modifiers" at the end too, but I think putting the deep in front in this case is clearer and sounds better and is also inline with equal/deepEqual.

@SamVerschueren
Copy link
Collaborator Author

Thanks for the feedback. We didn't discuss this. I'm fine with renaming it. I understand why the new name might be slightly better.

package.json Outdated
@@ -57,6 +57,7 @@
"awesome-typescript-loader": "^3.2.3",
"codecov": "^3.0.0",
"del-cli": "^1.1.0",
"is-plain-obj": "^1.1.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use is.plainObject

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could I miss that :)!

@sindresorhus
Copy link
Owner

Let's go with deepValuesOfType.

@SamVerschueren
Copy link
Collaborator Author

Feedback processed.

@SamVerschueren SamVerschueren changed the title Add object.valuesOfTypeDeep validator - fixes #51 Add object.deepValuesOfType validator - fixes #51 Feb 12, 2018
@sindresorhus sindresorhus merged commit 5b1b37a into master Feb 12, 2018
@sindresorhus sindresorhus deleted the iss51 branch February 12, 2018 19:41
@sindresorhus
Copy link
Owner

Perfect as always, Sammy :)

@SamVerschueren
Copy link
Collaborator Author

Haha, thanks 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants