-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object.deepValuesOfType validator - fixes #51 #53
Conversation
Did you discuss using the name |
Thanks for the feedback. We didn't discuss this. I'm fine with renaming it. I understand why the new name might be slightly better. |
package.json
Outdated
@@ -57,6 +57,7 @@ | |||
"awesome-typescript-loader": "^3.2.3", | |||
"codecov": "^3.0.0", | |||
"del-cli": "^1.1.0", | |||
"is-plain-obj": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use is.plainObject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How could I miss that :)!
Let's go with |
dd8aed6
to
38bcb02
Compare
Feedback processed. |
Perfect as always, Sammy :) |
Haha, thanks 🍻 |
Fixes #51.
Added the type definitions for
is-plain-obj
manually here. Will try to PR it to DefinitelyTyped when I find some time. Feel free to provide feedback in the meantime.