Add unitCount option
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Sep 10, 2018
test.js
Outdated
| t.is(m(1000 * 60 * 67, {unitsToShow: 2}), '~1h 7m'); | ||
| t.is(m(1000 * 60 * 67 * 24 * 465, {unitsToShow: 1}), '~1y'); | ||
| t.is(m(1000 * 60 * 67 * 24 * 465, {unitsToShow: 2}), '~1y 154d'); | ||
| t.is(m(1000 * 60 * 67 * 24 * 465, {unitsToShow: 3}), '~1y 154d 6h'); |
There was a problem hiding this comment.
I'd like to see some tests with this in combination with the verbose and compact option.
readme.md
Outdated
| @@ -84,6 +84,13 @@ Default: `false` | |||
|
|
|||
| Only show the first unit: `1h 10m` → `~1h`. | |||
|
|
|||
| ##### unitsToShow | |||
There was a problem hiding this comment.
I would call the option unitCount.
|
You have marked #29 (comment) as resolved, but I don't see it being done. |
sindresorhus
changed the title
unitsToShow option to limit number of units displayed
sindresorhus
changed the title
unitsToShow option to limit number of units displayedunitCount option
|
You also need to fix the merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is only possible to limit the number of units displayed to one unit. This would allow limiting to an arbitrary number of units without breaking the module's existing behavior.