Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ppid support for Linux #13

Closed
wants to merge 9 commits into from
Closed

Added ppid support for Linux #13

wants to merge 9 commits into from

Conversation

dominguesgm
Copy link
Contributor

@dominguesgm dominguesgm commented Jul 11, 2018

Included new test for ppid (checking if value is a number).
Mentioned Linux exclusivity in the readme.
Fixes #9

Gil added 7 commits July 11, 2018 01:08
…urned object.

Added 'ppid' to the test file as well.
fixed stupid mistake, x was being used instead of base 10 and ppid was returning NaN

Updated readme to mention that ppid does not work in windows

Travis build failing for node 6. Removed ppid test to make sure it was its fault

Created separate test for ppid

Fixed linter error
@dominguesgm
Copy link
Contributor Author

I'm just seeing this falied test on travis now. Apparently it fails on the test for the mem and cpu fields.

In line 1759 of the failed build:

    {
      cmd: '[ps] <defunct>',
      cpu: '0.0',
      memory: undefined,
      name: 'ps',
      pid: 2478,
      ppid: 2472,
    },

It shows mem as undefined in a defunct process. Is this a known issue? Because I'm not sure how or if my changes could have caused this.

@dominguesgm dominguesgm deleted the ppid_squashed branch July 18, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant