Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out our own pid #16

Closed
wants to merge 1 commit into from
Closed

Filter out our own pid #16

wants to merge 1 commit into from

Conversation

june07
Copy link

@june07 june07 commented Jul 27, 2018

No description provided.

@sindresorhus
Copy link
Owner

I agree this would be useful, but there's needs to be an option to opt-out of this. Someone might want to get all the processes including self. The option could be called includeSelf and default to true. This also needs docs and tests.

You also have changed permissions on all the files to 755. You need to revert that.

june07 pushed a commit to june07/ps-list that referenced this pull request Aug 1, 2018
@june07
Copy link
Author

june07 commented Aug 1, 2018

Closing in favor of pull #17. Made updates per feedback.

@june07 june07 closed this Aug 1, 2018
@sindresorhus
Copy link
Owner

In the future, don't open a new PR, that just creates needless noise. You can just push additional commits to the existing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants