Add CPU percentage to result #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamVerschueren
force-pushed
the
cpu-percentage
branch
from
5bf200f
to
b139b6e
Compare
|
@MarkTiedemann Do you know the best way to get the CPU percentage on Windows? |
|
@sindresorhus No, I honestly don't. (Been exploring some stuff, though, if anyone's interested: |
|
@SamVerschueren How about we just add a note about it not supporting Windows for now and open an issue about adding Windows support? |
|
Yes good idea. Otherwise I don't feel like this PR can be merged any time soon. |
|
When you have time, can you add a note to the readme about the property not being supported on Windows? |
|
Something like this? Feel free to improve. |
SamVerschueren
force-pushed
the
cpu-percentage
branch
from
c4d38d7
to
bf2f2d7
Compare
|
Weird, no clue why it fails on AppVeyor... |
sindresorhus
changed the title
|
Hey guys, any update on getting something similar to work on Windows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the CPU percentage to the result set. Still have to find a workaround for Windows so it's work in progress right now.
If #5 is merged, I will rebase to master.