Restore prompt_subst setopt when rendering prompt #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store the user setting for
prompt_subst
before changing it in the local scope ofprompt_pure_preprompt_render
. This allows us to restore it when we render the real prompt (PS1
) throughzle .redraw-prompt
.Fixes #230.
The was also one other way to fix this, to use anonymous functions in both places where we print the preprompt. Either solution is good imo, anonymous perhaps slightly cleaner (and doesn't depend on
zsh/parameter
) but I decided to go with this approach, mainly for the reason that I don't know when anonymous functions were introduced into zsh.Example of anonymous version: