Add zstyle color support to PS2 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Jul 17, 2019
|
Why does the color here needs to be customizable? Doesn't seem like something many would care about. What would you personally set it to? |
Aloxaf
added a commit
to Aloxaf/pure
that referenced
this pull request
Nov 10, 2019
|
@mafredri ⬆️ |
Sorry, missed this. The main reason I wanted to make this customizable is that |
|
Can you fix the merge conflict and add the color setting to the ASCII art that shows where in the prompt it is? |
sindresorhus
reviewed
Dec 1, 2019
mafredri
force-pushed
the
fix-ps2-colors
branch
from
5bd1b40
to
a24bf95
Compare
|
@sindresorhus I've amended the feedback and I decided to use @ashb's naming suggestion (thanks!) while I was at it. |
kgrz
added a commit
to kgrz/pure
that referenced
this pull request
Dec 11, 2019
* upstream/master: Renice the async worker (sindresorhus#505) Add zstyle color support to PS2 (sindresorhus#481) Improve issue template and system reporting (sindresorhus#517) Guard against (ana)conda changing PS1 (sindresorhus#516) 1.11.0 Add coloring for git dirty-asterisk (sindresorhus#491) Support changing color of the Git action part of the prompt (sindresorhus#486) Use ellipsis for continuation prompt (PS2) (sindresorhus#493) Fix missing ─ in readme color diagram Fix extra space in color diagram of readme Simplify the setup phase in the readme (sindresorhus#494) Use box characters for prompt diagram in the readme (sindresorhus#495)
kutsan
pushed a commit
to kutsan/pure
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important part of this PR changes the PS2 prompt to use the actual
prompt:success/prompt:errorcolors. The second part adds support for styling the PS2 part that prefixes the prompt indicator (e.g.... quote).Not sure what to call it, went with
prompt2:fadedas it's the faded part of the PS2, but it might as well be calledprompt2:parser_status.