Support changing color of the Git action part of the prompt #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
changed the title
|
@mafredri @sindresorhus Could you take a look please? Small PR to change the color of the "you are in the middle of a rebase" marker. |
sindresorhus
changed the title
|
Can you also add it to the ASCII diagram in https://github.com/sindresorhus/pure#colors? |
sindresorhus
requested changes
Sep 23, 2019
ashb
force-pushed
the
git-action-color
branch
from
9350033
to
57bc013
Compare
ashb
force-pushed
the
git-action-color
branch
from
57bc013
to
8b9c249
Compare
sindresorhus
approved these changes
Sep 29, 2019
mafredri
requested changes
Oct 8, 2019
| preprompt_parts+=("%F{$git_color}"'${prompt_pure_vcs_info[branch]}${prompt_pure_git_dirty}%f') | ||
| local branch="%F{$git_color}"'${prompt_pure_vcs_info[branch]}' | ||
| if [[ -n $prompt_pure_vcs_info[action] ]]; then | ||
| branch+="|%F{$prompt_pure_colors[git:action]}"'$prompt_pure_vcs_info[action]'"%F{$git_color}" |
There was a problem hiding this comment.
I've considered it good practice to end all %F with %f, but there are probably no real benefits there. What do you think?
There was a problem hiding this comment.
Given it was used on the next line in a format that does end with %f I didn't think it necessary here.
mafredri
approved these changes
Oct 14, 2019
sindresorhus
changed the title
|
Nice work :) |
kgrz
added a commit
to kgrz/pure
that referenced
this pull request
Dec 11, 2019
* upstream/master: Renice the async worker (sindresorhus#505) Add zstyle color support to PS2 (sindresorhus#481) Improve issue template and system reporting (sindresorhus#517) Guard against (ana)conda changing PS1 (sindresorhus#516) 1.11.0 Add coloring for git dirty-asterisk (sindresorhus#491) Support changing color of the Git action part of the prompt (sindresorhus#486) Use ellipsis for continuation prompt (PS2) (sindresorhus#493) Fix missing ─ in readme color diagram Fix extra space in color diagram of readme Simplify the setup phase in the readme (sindresorhus#494) Use box characters for prompt diagram in the readme (sindresorhus#495)
kutsan
pushed a commit
to kutsan/pure
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do a lot of rebasing and cherry-picking and I like to know when I'm in that mode, so I added an option to make it stand out more.
A picture is worth a thousand words: