Use ellipsis for continuation prompt (PS2) #493
Conversation
|
I kinda like this change but it's not clear to me why the order of
The idea of the dots was to signify that the previous prompt continues on this line, especially when |
|
Hmm, I did give all three variants a try (now/why not), and I do see that "now" kind of looks the best visually, not sure if it conveys the same message but I guess it could work 😄. Any thoughts on this @sindresorhus? |
|
For reference: |
That was my reasoning behind changing the ellipsis position, but it's highly subjective.
Here it's meaning is to it indicate that the "cmdand" continue on that line and that the user is expected to enter something. I see the ellipsis like the underline dots used on some forms to indicate where to write the content. |
|
Thanks for this @bricewge! |
* upstream/master: Renice the async worker (sindresorhus#505) Add zstyle color support to PS2 (sindresorhus#481) Improve issue template and system reporting (sindresorhus#517) Guard against (ana)conda changing PS1 (sindresorhus#516) 1.11.0 Add coloring for git dirty-asterisk (sindresorhus#491) Support changing color of the Git action part of the prompt (sindresorhus#486) Use ellipsis for continuation prompt (PS2) (sindresorhus#493) Fix missing ─ in readme color diagram Fix extra space in color diagram of readme Simplify the setup phase in the readme (sindresorhus#494) Use box characters for prompt diagram in the readme (sindresorhus#495)
I had a go at tweaking the PS2 prompt that have found unbalanced. Putting the ellipsis just before the prompt symbol looks more boring and replacing the 3 dots with an UTF-8 character reduce the line width. Related with the discussion at #323.
On the left you can see the current style and on the right the style in this PR.
I have no strong opinion on this PR, fell free to ditch it's not to your liking.
WDYT?
IssueHunt Summary
IssueHunt has been backed by the following sponsors. Become a sponsor