Do not show hostname when running in GitHub Codespaces #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
sindresorhus
approved these changes
Aug 15, 2021
mafredri
approved these changes
Aug 15, 2021
|
Thanks for the PR! |
wezzynl
added a commit
to wezzynl/pure
that referenced
this pull request
Sep 7, 2021
* upstream/main: Remove $ prompts from install commands (sindresorhus#607) 1.17.2 Improve Apple Silicon compatibility (sindresorhus#606) 1.17.1 Do not show hostname when running in GitHub Codespaces (sindresorhus#604) Fix version bumping script (sindresorhus#602) Add another sponsor to the readme 1.17.0 Add nix shell support (sindresorhus#599) Add Homebrew install instructions (sindresorhus#591) Update info about Fish port (sindresorhus#586) Remove antigen and antibody from instruction (sindresorhus#581) Update a link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in GitHub Codespaces pure thinks it's running inside a container (correctly) but we don't need the codespaces hostname when using the integrated terminal.
Tested this change using my dotfiles and the default codespaces image.