This repository has been archived by the owner on May 1, 2024. It is now read-only.
Trim long tasks name in the middle #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,20 @@ module.exports = function (grunt) { | |||
| return Math.max(acc, row[0].length); | |||
| }, 0); | |||
|
|
|||
| var maxBarWidth = (process.stdout.columns || 80) - (longestTaskName + 20); | |||
| var maxBarWidth = ((process.stdout.columns || 80) - 20) / 2; | |||
There was a problem hiding this comment.
I think longestTaskName should still be used to figure out the remaining space for the graph, but the comparison for longestTaskName needs to be aware of the max length a task name can be considering it will be condensed if too long.
|
Nice work on this. I added some feedback. |
|
@dylang I made changes |
|
@sorich87 great work, the changes look good to me. @sindresorhus I don't have further feedback. |
sindresorhus
added a commit
that referenced
this pull request
Nov 28, 2013
Trim long tasks name in the middle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13