fix(PackageJson): ensure Imports and Exports reflect Node.js expectations
#555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| A mapping of conditions and the paths to which they resolve. | ||
| */ | ||
| type ExportConditions = {[condition in ExportCondition]?: Exports}; |
There was a problem hiding this comment.
The ? here introduces undefined as a valid exports value in the type, which is not possible by JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems my previous PR was incomplete. While reviewing the Node.js source, I noticed a couple more issues. Namely: the
ImportsandExportstypes should both accept fallback arrays containing exports conditions objects with optional properties. Also, theImportstype should accept everything theExportstype accepts (with the added constraint that entry points must start with"#").This PR addresses these and adds tests.