Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the asharpisms #2

Closed
sinewalker opened this issue Dec 13, 2016 · 3 comments
Closed

Review the asharpisms #2

sinewalker opened this issue Dec 13, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@sinewalker
Copy link
Owner

I'm sure that all of the stuff Sharpie does makes sense, but there are a few surprises that are tripping me. So far

  • ssh is a function. What actually does it do?
  • what's all the Ruby shimm's about?
  • there is stuff for Vagrant that I don't understand

All of this should be documented in this Project's Wiki.

@sinewalker
Copy link
Owner Author

The Ruby shimm's come from Cowboy, actually. It's a submodule in vendor/. Still not sure what it does apart from some kind of "virtualenv/multiple runtimes" for Ruby? I don't think it interferes though, so I'll leave it alone

@sinewalker
Copy link
Owner Author

see issue #5 for the Ruby. Also the Vagrant boxes dir should be moved.

@sinewalker sinewalker self-assigned this Feb 8, 2017
sinewalker added a commit that referenced this issue Feb 14, 2017
another ASharpism folded into the core (issue #2 and #11)
@sinewalker
Copy link
Owner Author

I have folded much of Sharpies stuff into the main source files, and disabled the rest

@sinewalker sinewalker modified the milestone: 1.0-macOS Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant