Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAAL implementation is incomplete? #1

Closed
saifullah3396 opened this issue Oct 6, 2022 · 2 comments
Closed

VAAL implementation is incomplete? #1

saifullah3396 opened this issue Oct 6, 2022 · 2 comments

Comments

@saifullah3396
Copy link

Hi is VAAL implementation incorrect in this toolkit. I see that it is very different from the author's original implementation and it also looks incomplete, unusable. Can you please let me know if it is?
@gokyeongryeol
Copy link

I agree with your point. In current version, the parameter of VAE is not being updated.

@SineZHAN
Copy link
Owner

Hi is VAAL implementation incorrect in this toolkit. I see that it is very different from the author's original implementation and it also looks incomplete, unusable. Can you please let me know if it is?

Thank you for point out this issue, I found that I wrongly merged the vaal version (the old version lost discriminator part). I have updated it.

@SineZHAN SineZHAN closed this as completed Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@saifullah3396 @SineZHAN @gokyeongryeol