Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bookmarking strategy and adjust backoff #8

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Improve bookmarking strategy and adjust backoff #8

merged 2 commits into from
Feb 2, 2022

Conversation

loeakaodas
Copy link
Contributor

Description of change

  • adjusted backoff to increase max_retries for orders and order_items streams
  • increased factor for order_items stream to wait longer on each backoff attempt
  • added writing bookmark for every record written to handle failed runs gracefully on the next run

Manual QA steps

  • ran tap locally
  • ran with singer-check-tap
  • ran with target-stitch

Risks

  • minimal, no new functionality is introduced

Rollback steps

  • revert this branch

@luandy64 luandy64 merged commit 4db0d82 into main Feb 2, 2022
@luandy64 luandy64 deleted the fix/improve-bookmarking-strategy branch February 2, 2022 14:53
@luandy64 luandy64 mentioned this pull request Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luandy64 luandy64 luandy64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loeakaodas @luandy64