Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added retry logic for users stream #45

Merged
merged 5 commits into from
Sep 22, 2020
Merged

added retry logic for users stream #45

merged 5 commits into from
Sep 22, 2020

Conversation

jacobrobertbaca
Copy link
Contributor

Description of change

added retry logic for users stream

Manual QA steps

  • ran tests

Risks

  • low

Rollback steps

  • revert this branch

dmosorast
dmosorast approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, local testing confirmed that this will end after 60 and log appropriately

@dmosorast dmosorast merged commit 2375629 into master Sep 22, 2020
@dmosorast dmosorast deleted the add_retry branch September 22, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobrobertbaca @dmosorast