Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: common link is detected as a video link #1978

Merged
merged 2 commits into from
Jul 6, 2024
Merged

fix: common link is detected as a video link #1978

merged 2 commits into from
Jul 6, 2024

Conversation

CatHood0
Copy link
Collaborator

@CatHood0 CatHood0 commented Jul 6, 2024

Description

html link as "https://www.google.com" is converted to a video block at the Delta result instead just a normal link to a website.

HTML used:

<a href="https://www.google.com" type="text/html">fdsfsd</a>

Current result at Flutter Quill version (9.5.5):

 [{"insert": {'video': 'https://www.google.com'}]

Expected:

 [{"insert":"fdsfsd","attributes":{'link': 'https://www.google.com'}}]

Related Issues

Fix #1977

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • All existing and new tests are passing.
  • I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@CatHood0 CatHood0 requested a review from singerdmx July 6, 2024 01:49
@singerdmx singerdmx merged commit b00b29d into singerdmx:master Jul 6, 2024
2 checks passed
@CatHood0 CatHood0 deleted the fix_normal_link_as_video_link branch July 11, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML Conversion of Link
2 participants