Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PreserveInlineStylesRule #1980

Merged
merged 14 commits into from
Jul 6, 2024
Merged

Conversation

AtlasAutocode
Copy link
Collaborator

Description

Fix: PreserveInlineStylesRule to maintain inline styles, including font and size, when press double enter and up arrow key.
Fix: PreserveInlineStylesRule to maintain inline styles when using block styles.
Updated: sets of attribute keys associated with the same AttributeScope.
Tests: Added to ensure sets with the same AttributeScope match the set of all registered attribute keys.
Fix: Shortcut key control-F launched the search function. Background color was the old dark gray color. Set barrierColor to transparent to match the default for search when using the toolbar button.

Related Issues

Checklist

  • [ X ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ X ] I titled the PR using Conventional Commits.
  • [ X ] I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • [ X ] All existing and new tests are passing.
  • [ X ] I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • [ X ] No, this is not a breaking change.

@AtlasAutocode
Copy link
Collaborator Author

It looks like Rules were updated to pass in Document rather that Delta.
I have updated my PR for the change.

@singerdmx singerdmx merged commit 4a86f30 into singerdmx:master Jul 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All font settings are lost when you press Enter twice
2 participants