-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Mutable-X mods, and explicit shaping of SparseNDArray
#131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semantics look good; one formatting fix before this goes in and a few optional suggestions.
@@ -454,15 +467,6 @@ class SparseRead: | |||
|
|||
__slots__ = () | |||
|
|||
def coos(self) -> ReadIter[pa.SparseCOOTensor]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note to keep a pin in this depending upon the results of single-cell-data/TileDB-SOMA#952 (comment)
(if it does get spuriously removed here, it's not a huge problem; implementations are allowed to provide extra methods and features, and we can just re-add it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah @thetorpedodog totally not gonna land this PR until that one is resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved on latest commit: see also
single-cell-data/TileDB-SOMA#952 (comment)
4c843f6
to
741f1bc
Compare
Co-authored-by: paul fisher <paul.fisher@tiledb.com>
741f1bc
to
200f6ee
Compare
@bkmartinjr given |
I have not had a chance to take any look - sorry, lots of threads. Given the confusion on the design change, I would prefer we let that settle out, then review this PR. |
@bkmartinjr when you click through the links I wrote you'll see that restoration of COO is a go Pending changes on single-cell-data/TileDB-SOMA#952 include:
-- none of which affect the spec I had hoped to merge this PR but, sure, take all the time you need. Afternote: indeed there is one more mod, good call. :) |
.shape
as explicit capacity.shape
as explicit capacity [WIP / please do not review]
.shape
as explicit capacity [WIP / please do not review].shape
as explicit SparseNDArray
capacity [WIP / please do not review]
.shape
as explicit SparseNDArray
capacity [WIP / please do not review]SparseNDArray
[WIP / please do not review]
SparseNDArray
[WIP / please do not review]SparseNDArray
SparseNDArray
SparseNDArray
Implements the spec side of the plan laid out in issue single-cell-data/TileDB-SOMA#931.
This PR addresses only explicit shaping of
SparseNDArray
-- explicit shaping ofDataFrame
will be on a separate PR.