Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerations-API refinement #1746

Closed
johnkerl opened this issue Sep 29, 2023 · 2 comments
Closed

Enumerations-API refinement #1746

johnkerl opened this issue Sep 29, 2023 · 2 comments
Assignees

Comments

@johnkerl
Copy link
Member

johnkerl commented Sep 29, 2023

As of 1.5.0rc0, SOMADataFrame.create takes three new arguments, and should not.

  • create needs to take no new arguments
    • Those three values must be inferred from the passed-in Arrow schema
  • write will present new levels

Core support:

  • Permit zero levels at create (currently >= 1 is required)
  • Offer a streamlined extend_enumeration API

Out of scope and separately tracked: bit-width mutation for when the level-count passes the 8-bit or 16-bit boundary: #1745

This is multi-developer work involving @davisp @nguyenv @eddelbuettel @johnkerl ; mainly this issue mirrors [sc-34800].

Additional reminder: R/Python interop cases within apis/system/tests.

@johnkerl
Copy link
Member Author

[sc-34800]

@johnkerl
Copy link
Member Author

johnkerl commented Nov 6, 2023

Sub-issue: #1867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants