Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add back deprecated function tiledbsoma_build_index #2344

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Mar 27, 2024

Issue and/or context: #2343

Changes:
Restore function tiledbsoma_build_index. Deprecate instead of removing.

@jp-dark jp-dark requested a review from johnkerl March 27, 2024 21:33
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #2344 (1a2ce4c) into main (e6822fb) will increase coverage by 11.88%.
The diff coverage is 66.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2344       +/-   ##
===========================================
+ Coverage   78.68%   90.56%   +11.88%     
===========================================
  Files         140       37      -103     
  Lines       10760     3879     -6881     
  Branches      217        0      -217     
===========================================
- Hits         8466     3513     -4953     
+ Misses       2195      366     -1829     
+ Partials       99        0       -99     
Flag Coverage Δ
libtiledbsoma ?
python 90.56% <66.66%> (-0.02%) ⬇️
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.56% <66.66%> (-0.02%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member

johnkerl commented Mar 27, 2024

Spurious MacOS so-copy CI fail is a KP #2237 -- I restarted it

@johnkerl johnkerl merged commit 6e9c58b into main Mar 27, 2024
27 checks passed
@johnkerl johnkerl deleted the dark/add-back-function branch March 27, 2024 22:54
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
* Add back deprecated function `tiledbsoma_build_index`

* Add function to __all__
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
* Add back deprecated function `tiledbsoma_build_index`

* Add function to __all__
johnkerl pushed a commit that referenced this pull request Mar 27, 2024
* Add back deprecated function `tiledbsoma_build_index`

* Add function to __all__

Co-authored-by: Julia Dark <24235303+jp-dark@users.noreply.github.com>
johnkerl pushed a commit that referenced this pull request Mar 27, 2024
* Add back deprecated function `tiledbsoma_build_index`

* Add function to __all__

Co-authored-by: Julia Dark <24235303+jp-dark@users.noreply.github.com>
@johnkerl johnkerl changed the title Add back deprecated function tiledbsoma_build_index [python] Add back deprecated function tiledbsoma_build_index Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants