[python] Code-review-feedback follow-up from #2434 #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/ingest-performance-improvement
branch
from
a54548d
to
aab27cb
Compare
nguyenv
approved these changes
Apr 12, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 37 37
Lines 3919 3919
=======================================
Hits 3548 3548
Misses 371 371
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of @nguyenv 's last comments on #2434, I applied in sandbox but failed to git-push to remote before merging the latter. Here they are.