[r] Fix builds against current TileDB Embedded #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
changed the title
|
Suggested subject change above. It also broke tests here were I tend to be on current TileDB Embedded as the nightlies are -- but the need goes beyond the nightlies to all build with 'dev' versions of TileDB Embedded and hence likely next versions. |
johnkerl
added a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: It never made sense to set row/cell order in array-schema creation. But TileDB-Inc/TileDB#4973 recently formalized this.
We shouldn't ask for unordered at schema-create time.
See also: TileDB-Inc/TileDB-Py#1970
Note the above core change isn't in 2.23, only in
dev-- but https://github.com/TileDB-Inc/tiledbsoma-feedstock has nightlies which point at core dev: https://github.com/jdblischak/centralized-tiledb-nightlies/issues/6#issuecomment-2115841783Changes:
Notes for Reviewer: