Feature/singlestore type tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rodriguespn
force-pushed
the
feature/singlestore-type-tests
branch
from
2c4a8ba
to
967ab83
Compare
Rodriguespn
force-pushed
the
feature/singlestore-type-tests
branch
from
967ab83
to
ae78e04
Compare
mitchwadair
reviewed
Aug 20, 2024
mitchwadair
approved these changes
Aug 20, 2024
|
@mitchwadair yes, it's just the copy/paste/rename of the type tests from MySQL. I also removed the foreign key type tests from MySQL since SingleStore doesn't support FKs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type tests test the type safety of the drizzle-orm operations and are located in the “drizzle-orm/type-tests” directory.
Copied and renamed every MySQL reference to singlestore on the
drizzle-orm/src/type-testsdirectory.Also, I removed the foreign key and check constraint type tests, since they are not supported by singlestore.
Note: Defined
intersectAllandexcludeAllsql functions for SingleStore, since they were defined for MySQL and not for SingleStore and were used on the type tests