Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop IE11 and Safari 9 from Sauce Labs test runners #376

Merged
merged 2 commits into from
May 3, 2021

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented May 3, 2021

Purpose (TL;DR) - mandatory

Background (Problem in detail) - optional

See discussion in #375 and sinonjs/sinon#2359

@fatso83 fatso83 changed the title Drop IE11 and Safari 9 Drop IE11 and Safari 9 from Sauce Labs test runners May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #376 (3e07631) into master (07d90ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           1        1           
  Lines         553      553           
=======================================
  Hits          517      517           
  Misses         36       36           
Flag Coverage Δ
unit 93.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d90ce...3e07631. Read the comment docs.

@fatso83 fatso83 merged commit 254eb97 into sinonjs:master May 3, 2021
@fatso83 fatso83 deleted the remove-unsupported branch May 3, 2021 09:16
@benjamingr
Copy link
Member

Should we do a version that modernizes the codebase? (I'm happy to run the code through transforms that modernize it if we don't need to support IE11)

@fatso83
Copy link
Contributor Author

fatso83 commented May 3, 2021

I would not mind that. The only problem I have with large touch-everything stuff like running Prettier, Eslint and transforms on the code is that it makes git blame a lot less useful, but I can live with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants