Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run prettier as part of eslint #404

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 22, 2021

Purpose (TL;DR) - mandatory

I didn't know we had prettier set up (https://github.com/sinonjs/fake-timers/runs/3673842832?check_suite_focus=true) - it's better to just run it as part of eslint both for eslint --fix and the pre-commit hook. And my IDE will now autoformat on save 🙂

Note that we can probably remove the prettier --check thing as eslint will now report any formatting errors.

Negates the need for #402

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #404 (0e2b4c1) into master (f434b69) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files           1        1           
  Lines         586      586           
=======================================
  Hits          550      550           
  Misses         36       36           
Flag Coverage Δ
unit 93.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f434b69...0e2b4c1. Read the comment docs.

@fatso83 fatso83 merged commit 9f1ee85 into sinonjs:master Sep 22, 2021
@fatso83
Copy link
Contributor

fatso83 commented Sep 22, 2021

Nice cleanup!

@SimenB SimenB deleted the prettier-from-eslint branch September 22, 2021 22:14
@mroderick
Copy link
Member

I don't think this was necessary, but if it makes you happier to configure your IDE this way ... 🤷

@fatso83
Copy link
Contributor

fatso83 commented Nov 11, 2021

Does all the things the old stuff did and a bit more, while making the dev tools people use play better: seems like a win to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants