-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hasRef #419
add hasRef #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Tests? 😀 |
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 95.46% 95.49% +0.02%
==========================================
Files 1 1
Lines 618 621 +3
==========================================
+ Hits 590 593 +3
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Yeah, realize we are talking about a handful of lines here, but a little test to demonstrate use would be nice |
Sorry for the delay, I added the tests as you asked (I hope..) Please let me know if you think I need to add/remove something. |
This failed due to not running Prettier (which I fixed for you), but the tests fail as well in Chromium, since there is no conditional checking here. |
This has been published to the npm registry as |
Purpose (TL;DR) - mandatory
add refed attribute to the res object
add this as required in the issue - Missing hasRef for Node #408