-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get global object properly #72
Conversation
Thanks for the PR. Unfortunately it does not pass our tests. It specifically fails at the linting stage. Could you fix it and squash the resulting commits? |
@fatso83 what comment do I have to put to make jslint allow
|
@jedwards1211 Don't worry too much about BitHound right now. It does some linting that we cannot do anything with until we switch to eslint, as jslint is not supported with it. Regarding the eval error: I am not sure what you are talking about. I just ran
Are you simply talking about BitHound, or are you getting some other results than me? |
Yeah, I was just talking about BitHound. |
Well, then just delete the comment, squash the commits, and it's good to go |
3024c98
to
f8b6777
Compare
f8b6777
to
87217a5
Compare
Okay, done! |
You still need to rebase your work off |
I rebased it and merged it as 47b30ed |
fix #71