Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get global object properly #72

Closed
wants to merge 1 commit into from

Conversation

jedwards1211
Copy link
Contributor

fix #71

@fatso83
Copy link
Contributor

fatso83 commented Jun 28, 2016

Thanks for the PR. Unfortunately it does not pass our tests. It specifically fails at the linting stage. Could you fix it and squash the resulting commits?

@jedwards1211
Copy link
Contributor Author

jedwards1211 commented Jun 28, 2016

@fatso83 what comment do I have to put to make jslint allow new Function('return this')?

/* jslint evil: true */ doesn't seem to work.
Also, there are some issues in bitHound regarding code I didn't touch.

@fatso83
Copy link
Contributor

fatso83 commented Jul 12, 2016

@jedwards1211 Don't worry too much about BitHound right now. It does some linting that we cannot do anything with until we switch to eslint, as jslint is not supported with it.

Regarding the eval error: I am not sure what you are talking about. I just ran npm run lint and got no errors. I even removed your jslint config comment and still got no errors.

npm run lint

> lolex@1.5.0 lint /Users/carl-erik.kopseng/dev-priv/lolex
> jslint src/**/*.js


src/lolex-src.js is OK.

Are you simply talking about BitHound, or are you getting some other results than me?

@jedwards1211
Copy link
Contributor Author

Yeah, I was just talking about BitHound.

@fatso83
Copy link
Contributor

fatso83 commented Jul 13, 2016

Well, then just delete the comment, squash the commits, and it's good to go ☺️

@jedwards1211
Copy link
Contributor Author

Okay, done!

@fatso83
Copy link
Contributor

fatso83 commented Jul 13, 2016

You still need to rebase your work off master as it is out-of-date and cannot be merged.

@fatso83
Copy link
Contributor

fatso83 commented Jul 14, 2016

I rebased it and merged it as 47b30ed

@fatso83 fatso83 closed this Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError when using npm package in the browser; get global object properly
2 participants