Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for comparing symbols #127

Merged
merged 1 commit into from
Oct 12, 2019
Merged

add support for comparing symbols #127

merged 1 commit into from
Oct 12, 2019

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Oct 12, 2019

Purpose (TL;DR) - mandatory

Support comparing Symbol in samsam.

Discussion: #112

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mgred mgred self-assigned this Oct 12, 2019
@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #127 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   99.79%   99.79%   +<.01%     
==========================================
  Files          25       25              
  Lines         491      493       +2     
==========================================
+ Hits          490      492       +2     
  Misses          1        1
Flag Coverage Δ
#unit 99.79% <100%> (ø) ⬆️
Impacted Files Coverage Δ
lib/match.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef1272d...3aad357. Read the comment docs.

@mroderick mroderick added the semver:minor changes will cause a new minor version label Oct 12, 2019
@mroderick mroderick merged commit 5bcf623 into master Oct 12, 2019
@mroderick mroderick deleted the support-symbol branch October 12, 2019 12:59
@mroderick
Copy link
Member

I rebased the conflicts out of this PR and have merged it

@mroderick
Copy link
Member

This has been published in @sinonjs/samsam@4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor changes will cause a new minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants