Refactor and fix a couple of issues #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And prefer boolean logic over conditionals
This was referenced Jul 22, 2018
mantoni
reviewed
Jul 22, 2018
package.json
Outdated
| @@ -28,7 +28,9 @@ | |||
| "lib/", | |||
| "!lib/**/*.test.js" | |||
| ], | |||
| "dependencies": {}, | |||
| "dependencies": { | |||
| "array-from": "2.1.1" | |||
There was a problem hiding this comment.
Did you add this with the exact version number on purpose?
There was a problem hiding this comment.
Pushed a temporary fix, I'll fold it in when we're ready to merge
mroderick
force-pushed
the
refactor-and-fix-issues
branch
from
212ac86
to
a58b284
Compare
And use polyfill, as IE11 doesn't support
IE11 [doesn't support collection arguments][1]. Disabling the check means that linting will pass, when it should not. Since the aim is to keep this library compatible with IE11, then the tests should be able to run in IE11. Instead of disabling the check for use of invalid use `new Set()`, replace invalid calls to `new Set()` with a helper `createSet()` that supports collection arguments. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set
It is much faster in the runtimes we care about: * https://gist.github.com/mroderick/daec6d96e476048e60c2ba30408fbbed * https://jsperf.com/getindex-vs-indexof/1
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to the discussion in sinonjs/referee#29.
It contains the same changes as in the branch mentioned in sinonjs/referee#29, just packaged slightly differently
I've tried to keep each commit focused on just one thing and have tried to give a decent order to the changes, to make it easier to follow.
Main themes
deepEqualinsinonin preparation of consolidating everything insamsamindexOfinstead of homegrown solutionHow to verify - mandatory
npm installnpm testChecklist for author
npm run lintpasses